Skip to content

[skip changelog] Add documentation for library components of the gRPC interface #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2020
Merged

[skip changelog] Add documentation for library components of the gRPC interface #692

merged 7 commits into from
Jun 18, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented May 8, 2020

Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce?

Add explanatory comments for the library components of the gRPC interface to the source code. These comments will be included in the generated gRPC interface documentation.

  • What is the current behavior?

There is insufficient explanation of the gRPC interface in the documentation.

  • What is the new behavior?

Improved documentation of the gRPC interface.

  • Does this PR introduce a breaking change?

No

@per1234 per1234 added topic: documentation Related to documentation for the project component/gRPC labels May 8, 2020
@rsora rsora requested a review from cmaglie May 12, 2020 17:18
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @per1234, excellent work!
Some suggestions we made together with @cmaglie

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@rsora rsora merged commit 5369917 into arduino:master Jun 18, 2020
umbynos pushed a commit that referenced this pull request Jun 25, 2020
… interface (#692)

* [skip changelog] Add documentation for library components of the gRPC interface

Comments added to the .proto files are included in the generated gRPC interface documentation.

* Correct documentation re: relative vs absolute paths provided by Library message fields

Co-authored-by: Roberto Sora <[email protected]>

* Use preferred "platform" term in gRPC interface documentation

The official term is now "platform", rather than the previous ambiguous "core".

Co-authored-by: Roberto Sora <[email protected]>

* Fix formatting of gRPC interface documentation

* Fix incorrect documentation for task_progress field of LibraryUninstall response

* Document that library version is the key of the releases map

* Update gRPC interface code comments

Co-authored-by: Roberto Sora <[email protected]>
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants